netfilter: nf_ct_sip: extend RCU read lock in set_expected_rtp_rtcp()
authorholger@eitzenberger.org <holger@eitzenberger.org>
Fri, 20 Sep 2013 20:43:04 +0000 (22:43 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Fri, 27 Sep 2013 14:17:47 +0000 (16:17 +0200)
commitb21613aeb649293946556410ff10dbb8c639f298
tree9debb3a0e3bb9b99bf5b7cdacee5e5630e9eec36
parent8ce440610357b77587433d0df647cea69a6890a8
netfilter: nf_ct_sip: extend RCU read lock in set_expected_rtp_rtcp()

Currently set_expected_rtp_rtcp() in the SIP helper uses
rcu_dereference() two times to access two different NAT hook
functions. However, only the first one is protected by the RCU
reader lock, but the 2nd isn't. Fix it by extending the RCU
protected area.

This is more a cosmetic thing since we rely on all netfilter hooks
being rcu_read_lock()ed by nf_hook_slow() in many places anyways,
as Patrick McHardy clarified.

Signed-off-by: Holger Eitzenberger <holger.eitzenberger@sophos.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_conntrack_sip.c