scsi: ufs: Clean up completed request without interrupt notification
authorStanley Chu <stanley.chu@mediatek.com>
Tue, 11 Aug 2020 14:18:58 +0000 (16:18 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 18 Aug 2020 02:09:13 +0000 (22:09 -0400)
commitb10178ee7fa88b68a9e8adc06534d2605cb0ec23
tree530a1280474280dd59e78103718244562fcb6a7b
parent127d5f7c4b653b8be5eb3b2c7bbe13728f9003ff
scsi: ufs: Clean up completed request without interrupt notification

If somehow no interrupt notification is raised for a completed request and
its doorbell bit is cleared by host, UFS driver needs to cleanup its
outstanding bit in ufshcd_abort(). Otherwise, system may behave abnormally
in the following scenario:

After ufshcd_abort() returns, this request will be requeued by SCSI layer
with its outstanding bit set. Any future completed request will trigger
ufshcd_transfer_req_compl() to handle all "completed outstanding bits". At
this time the "abnormal outstanding bit" will be detected and the "requeued
request" will be chosen to execute request post-processing flow. This is
wrong because this request is still "alive".

Link: https://lore.kernel.org/r/20200811141859.27399-2-huobean@gmail.com
Reviewed-by: Can Guo <cang@codeaurora.org>
Acked-by: Avri Altman <avri.altman@wdc.com>
Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
Signed-off-by: Bean Huo <beanhuo@micron.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ufs/ufshcd.c