random: skip fast_init if hwrng provides large chunk of entropy
authorJason A. Donenfeld <Jason@zx2c4.com>
Tue, 22 Mar 2022 00:48:05 +0000 (18:48 -0600)
committerJason A. Donenfeld <Jason@zx2c4.com>
Fri, 25 Mar 2022 14:49:40 +0000 (08:49 -0600)
commitaf704c856e888fb044b058d731d61b46eeec499d
tree1229cfee1aef6c49009fb558fd0752752665087b
parent34af78c4e616c359ed428d79fe4758a35d2c5473
random: skip fast_init if hwrng provides large chunk of entropy

At boot time, EFI calls add_bootloader_randomness(), which in turn calls
add_hwgenerator_randomness(). Currently add_hwgenerator_randomness()
feeds the first 64 bytes of randomness to the "fast init"
non-crypto-grade phase. But if add_hwgenerator_randomness() gets called
with more than POOL_MIN_BITS of entropy, there's no point in passing it
off to the "fast init" stage, since that's enough entropy to bootstrap
the real RNG. The "fast init" stage is just there to provide _something_
in the case where we don't have enough entropy to properly bootstrap the
RNG. But if we do have enough entropy to bootstrap the RNG, the current
logic doesn't serve a purpose. So, in the case where we're passed
greater than or equal to POOL_MIN_BITS of entropy, this commit makes us
skip the "fast init" phase.

Cc: Dominik Brodowski <linux@dominikbrodowski.net>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
drivers/char/random.c