PCI: Disable all BAR sizing for devices with non-compliant BARs
authorPrarit Bhargava <prarit@redhat.com>
Wed, 11 May 2016 16:27:16 +0000 (12:27 -0400)
committerBjorn Helgaas <bhelgaas@google.com>
Mon, 16 May 2016 20:57:56 +0000 (15:57 -0500)
commitad67b437f187ea818b2860524d10f878fadfdd99
tree75c7ce95fcd0000f22fe303792130552d667c15d
parentda77b67195de1c65bef4908fa29967c4d0af2da2
PCI: Disable all BAR sizing for devices with non-compliant BARs

b84106b4e229 ("PCI: Disable IO/MEM decoding for devices with non-compliant
BARs") disabled BAR sizing for BARs 0-5 of devices that don't comply with
the PCI spec.  But it didn't do anything for expansion ROM BARs, so we
still try to size them, resulting in warnings like this on Broadwell-EP:

  pci 0000:ff:12.0: BAR 6: failed to assign [mem size 0x00000001 pref]

Move the non-compliant BAR check from __pci_read_base() up to
pci_read_bases() so it applies to the expansion ROM BAR as well as
to BARs 0-5.

Note that direct callers of __pci_read_base(), like sriov_init(), will now
bypass this check.  We haven't had reports of devices with broken SR-IOV
BARs yet.

[bhelgaas: changelog]
Fixes: b84106b4e229 ("PCI: Disable IO/MEM decoding for devices with non-compliant BARs")
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
CC: stable@vger.kernel.org
CC: Thomas Gleixner <tglx@linutronix.de>
CC: Ingo Molnar <mingo@redhat.com>
CC: "H. Peter Anvin" <hpa@zytor.com>
CC: Andi Kleen <ak@linux.intel.com>
drivers/pci/probe.c