vfs: fix pipe counter breakage
authorAl Viro <viro@ZenIV.linux.org.uk>
Tue, 12 Mar 2013 02:59:49 +0000 (02:59 +0000)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 12 Mar 2013 15:29:17 +0000 (08:29 -0700)
commita930d8790552658140d7d0d2e316af4f0d76a512
tree143e42bbaa41be61151389e386ba4cecc3bf6b3f
parent7c6baa304b841673d3a55ea4fcf9a5cbf7a1674b
vfs: fix pipe counter breakage

If you open a pipe for neither read nor write, the pipe code will not
add any usage counters to the pipe, causing the 'struct pipe_inode_info"
to be potentially released early.

That doesn't normally matter, since you cannot actually use the pipe,
but the pipe release code - particularly fasync handling - still expects
the actual pipe infrastructure to all be there.  And rather than adding
NULL pointer checks, let's just disallow this case, the same way we
already do for the named pipe ("fifo") case.

This is ancient going back to pre-2.4 days, and until trinity, nobody
naver noticed.

Reported-by: Dave Jones <davej@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/pipe.c