tcp: consider using standard rtx logic in tcp_rcv_fastopen_synack()
authorEric Dumazet <edumazet@google.com>
Thu, 11 Mar 2021 20:35:05 +0000 (12:35 -0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 12 Mar 2021 02:35:31 +0000 (18:35 -0800)
commita7abf3cd76e1e190a2c22afe5ffd0f695c7641b0
tree2b70863783d21ad6b50503bf27ca2e5a54555b8b
parentf4dae54e486d528d4dd98df116e7a522bbf12667
tcp: consider using standard rtx logic in tcp_rcv_fastopen_synack()

Jakub reported Data included in a Fastopen SYN that had to be
retransmit would have to wait for an RTO if TX completions are slow,
even with prior fix.

This is because tcp_rcv_fastopen_synack() does not use standard
rtx logic, meaning TSQ handler exits early in tcp_tsq_write()
because tp->lost_out == tp->retrans_out

Lets make tcp_rcv_fastopen_synack() use standard rtx logic,
by using tcp_mark_skb_lost() on the skb thats needs to be
sent again.

Not this raised a warning in tcp_fastretrans_alert() during my tests
since we consider the data not being aknowledged
by the receiver does not mean packet was lost on the network.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Jakub Kicinski <kuba@kernel.org>
Cc: Neal Cardwell <ncardwell@google.com>
Cc: Yuchung Cheng <ycheng@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_input.c