reset: remove redundant null check on pointer dev
authorColin Ian King <colin.king@canonical.com>
Fri, 10 May 2019 09:58:32 +0000 (10:58 +0100)
committerPhilipp Zabel <p.zabel@pengutronix.de>
Thu, 4 Jul 2019 10:10:55 +0000 (12:10 +0200)
commita71dcd3757e29cc8b43383ff18595d707cf08345
treeb214062fd64dc92d0179d6d69a6d577835b5761c
parenta188339ca5a396acc588e5851ed7e19f66b0ebd9
reset: remove redundant null check on pointer dev

Pointer dev is being dereferenced when passed to the inlined
functon dev_name, however, dev is later being null checked
so at first this seems like a potential null pointer dereference.

In fact, _reset_control_get_from_lookup is only ever called from
__reset_control_get, right after checking dev->of_node hence
dev can never be null.  Clean this up by removing the redundant
null check.

Thanks to Philipp Zabel for spotting that dev can never be null.

Addresses-Coverity: ("Dereference before null check")
Fixes: 6691dffab0ab ("reset: add support for non-DT systems")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
drivers/reset/core.c