cifs: fix leaked reference on requeued write
authorAdam McCoy <adam@forsedomani.com>
Wed, 13 May 2020 11:53:30 +0000 (11:53 +0000)
committerSteve French <stfrench@microsoft.com>
Thu, 14 May 2020 22:47:01 +0000 (17:47 -0500)
commita48137996063d22ffba77e077425f49873856ca5
tree0ea55985df6a5836586ceaee78db68b026523f26
parent9bd21d4b1a767c3abebec203342f3820dcb84662
cifs: fix leaked reference on requeued write

Failed async writes that are requeued may not clean up a refcount
on the file, which can result in a leaked open. This scenario arises
very reliably when using persistent handles and a reconnect occurs
while writing.

cifs_writev_requeue only releases the reference if the write fails
(rc != 0). The server->ops->async_writev operation will take its own
reference, so the initial reference can always be released.

Signed-off-by: Adam McCoy <adam@forsedomani.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
CC: Stable <stable@vger.kernel.org>
Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
fs/cifs/cifssmb.c