dm ioctl: remove unnecessary check when using dm_get_mdptr()
authorHou Tao <houtao1@huawei.com>
Fri, 16 Dec 2022 04:23:53 +0000 (12:23 +0800)
committerMike Snitzer <snitzer@kernel.org>
Fri, 17 Feb 2023 19:49:21 +0000 (14:49 -0500)
commita2f998a78a425edde5a1a1973c1d4854fe9d019f
tree291cf12c7f177e9c60fbc9a0772b69364f64cf80
parent69868bebfe8e9a47b0d8a12f7473b8a3b7239ef3
dm ioctl: remove unnecessary check when using dm_get_mdptr()

__hash_remove() removes hash_cell with _hash_lock locked, so acquiring
_hash_lock can guarantee no-NULL hc returned from dm_get_mdptr() must
have not been removed and hc->md must still be md.

__hash_remove() also acquires dm_hash_cells_mutex before setting mdptr
as NULL. So in dm_copy_name_and_uuid(), after acquiring
dm_hash_cells_mutex and ensuring returned hc is not NULL, the returned
hc must still be alive and hc->md must still be md.

Remove the unnecessary hc->md != md checks when using dm_get_mdptr()
with _hash_lock or dm_hash_cells_mutex acquired.

Signed-off-by: Hou Tao <houtao1@huawei.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
drivers/md/dm-ioctl.c