drm/bridge: tc358768: Fix use of uninitialized variable
authorTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Wed, 6 Sep 2023 06:50:49 +0000 (09:50 +0300)
committerRobert Foss <rfoss@kernel.org>
Wed, 20 Sep 2023 11:48:35 +0000 (13:48 +0200)
commita2d9036615f0adfa5b0a46bb2ce42ef1d9a04fbe
tree74227f5cd49f70a668ef5c1e801bb323ef91af57
parent1716b1891e1de05e2c20ccafa9f58550f3539717
drm/bridge: tc358768: Fix use of uninitialized variable

smatch reports:

drivers/gpu/drm/bridge/tc358768.c:223 tc358768_update_bits() error: uninitialized symbol 'orig'.

Fix this by bailing out from tc358768_update_bits() if the
tc358768_read() produces an error.

Fixes: ff1ca6397b1d ("drm/bridge: Add tc358768 driver")
Reviewed-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
Tested-by: Maxim Schwalm <maxim.schwalm@gmail.com> # Asus TF700T
Tested-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Robert Foss <rfoss@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230906-tc358768-v4-2-31725f008a50@ideasonboard.com
drivers/gpu/drm/bridge/tc358768.c