net: fec: Do not use netdev messages too early
authorFabio Estevam <festevam@gmail.com>
Thu, 6 Jun 2019 12:40:33 +0000 (09:40 -0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 6 Jun 2019 18:15:42 +0000 (11:15 -0700)
commita19a0582363b9a5f8ba812f34f1b8df394898780
tree7f024caf6bac0a2e12c4ae6cda5d2717faf685db
parentfe1e0713bbe84c6796b01d50a55ce4e324141161
net: fec: Do not use netdev messages too early

When a valid MAC address is not found the current messages
are shown:

fec 2188000.ethernet (unnamed net_device) (uninitialized): Invalid MAC address: 00:00:00:00:00:00
fec 2188000.ethernet (unnamed net_device) (uninitialized): Using random MAC address: aa:9f:25:eb:7e:aa

Since the network device has not been registered at this point, it is better
to use dev_err()/dev_info() instead, which will provide cleaner log
messages like these:

fec 2188000.ethernet: Invalid MAC address: 00:00:00:00:00:00
fec 2188000.ethernet: Using random MAC address: aa:9f:25:eb:7e:aa

Tested on a imx6dl-pico-pi board.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/fec_main.c