drivers: net: fix memory leak in peak_usb_create_dev
authorPavel Skripkin <paskripkin@gmail.com>
Thu, 1 Apr 2021 13:27:52 +0000 (16:27 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 1 Apr 2021 22:55:15 +0000 (15:55 -0700)
commita0b96b4a62745397aee662670cfc2157bac03f55
treea4de8dcfa238716b99259f25706b7e3a5cf74ba1
parent98184612aca0a9ee42b8eb0262a49900ee9eef0d
drivers: net: fix memory leak in peak_usb_create_dev

syzbot reported memory leak in peak_usb.
The problem was in case of failure after calling
->dev_init()[2] in peak_usb_create_dev()[1]. The data
allocated int dev_init() wasn't freed, so simple
->dev_free() call fix this problem.

backtrace:
    [<0000000079d6542a>] kmalloc include/linux/slab.h:552 [inline]
    [<0000000079d6542a>] kzalloc include/linux/slab.h:682 [inline]
    [<0000000079d6542a>] pcan_usb_fd_init+0x156/0x210 drivers/net/can/usb/peak_usb/pcan_usb_fd.c:868   [2]
    [<00000000c09f9057>] peak_usb_create_dev drivers/net/can/usb/peak_usb/pcan_usb_core.c:851 [inline] [1]
    [<00000000c09f9057>] peak_usb_probe+0x389/0x490 drivers/net/can/usb/peak_usb/pcan_usb_core.c:949

Reported-by: syzbot+91adee8d9ebb9193d22d@syzkaller.appspotmail.com
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/can/usb/peak_usb/pcan_usb_core.c