PCI/MSI: Prevent UAF in error path
authorThomas Gleixner <tglx@linutronix.de>
Wed, 19 Jan 2022 17:54:52 +0000 (18:54 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Fri, 21 Jan 2022 01:14:46 +0000 (02:14 +0100)
commita0af3d1104f752b6d0dba71788e3fddd67c857a7
tree36825fdf15c9fd187c10b64c6ed3e63768db549a
parent1d1df41c5a33359a00e919d54eaebfb789711fdc
PCI/MSI: Prevent UAF in error path

When the core MSI allocation fails, then the PCI/MSI code uses an already
freed MSI descriptor to unmask the MSI mask register in order to bring it back
into reset state.

Remove MSI_FLAG_FREE_MSI_DESCS from the PCI/MSI irqdomain flags and let the
PCI/MSI code free the MSI descriptors after usage.

Fixes: 0f62d941acf9 ("genirq/msi: Provide msi_domain_alloc/free_irqs_descs_locked()")
Reported-by: Tong Zhang <ztong0001@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Tong Zhang <ztong0001@gmail.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Link: https://lore.kernel.org/r/87r1938vbn.ffs@tglx
drivers/pci/msi/irqdomain.c
drivers/pci/msi/legacy.c