selinux: fix setting of security labels on NFS
authorJ. Bruce Fields <bfields@redhat.com>
Thu, 4 Jun 2015 19:57:25 +0000 (15:57 -0400)
committerPaul Moore <pmoore@redhat.com>
Fri, 5 Jun 2015 18:21:48 +0000 (14:21 -0400)
commit9fc2b4b436cff7d8403034676014f1be9d534942
tree08507047792c89c8a8c384df14ce3fddc04adbad
parent42a9699a9fa179c0054ea3cf5ad3cc67104a6162
selinux: fix setting of security labels on NFS

Before calling into the filesystem, vfs_setxattr calls
security_inode_setxattr, which ends up calling selinux_inode_setxattr in
our case.  That returns -EOPNOTSUPP whenever SBLABEL_MNT is not set.
SBLABEL_MNT was supposed to be set by sb_finish_set_opts, which sets it
only if selinux_is_sblabel_mnt returns true.

The selinux_is_sblabel_mnt logic was broken by eadcabc697e9 "SELinux: do
all flags twiddling in one place", which didn't take into the account
the SECURITY_FS_USE_NATIVE behavior that had been introduced for nfs
with eb9ae686507b "SELinux: Add new labeling type native labels".

This caused setxattr's of security labels over NFSv4.2 to fail.

Cc: stable@kernel.org # 3.13
Cc: Eric Paris <eparis@redhat.com>
Cc: David Quigley <dpquigl@davequigley.com>
Reported-by: Richard Chan <rc556677@outlook.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
[PM: added the stable dependency]
Signed-off-by: Paul Moore <pmoore@redhat.com>
security/selinux/hooks.c