loop: loop_set_status_from_info() check before assignment
authorZhong Jinghua <zhongjinghua@huawei.com>
Tue, 21 Feb 2023 09:50:27 +0000 (17:50 +0800)
committerJens Axboe <axboe@kernel.dk>
Thu, 23 Feb 2023 03:43:09 +0000 (20:43 -0700)
commit9f6ad5d533d1c71e51bdd06a5712c4fbc8768dfa
tree279a5d36c086e0096896304e9086546305181654
parent9c7c4bc986932218fd0df9d2a100509772028fb1
loop: loop_set_status_from_info() check before assignment

In loop_set_status_from_info(), lo->lo_offset and lo->lo_sizelimit should
be checked before reassignment, because if an overflow error occurs, the
original correct value will be changed to the wrong value, and it will not
be changed back.

More, the original patch did not solve the problem, the value was set and
ioctl returned an error, but the subsequent io used the value in the loop
driver, which still caused an alarm:

loop_handle_cmd
 do_req_filebacked
  loff_t pos = ((loff_t) blk_rq_pos(rq) << 9) + lo->lo_offset;
  lo_rw_aio
   cmd->iocb.ki_pos = pos

Fixes: c490a0b5a4f3 ("loop: Check for overflow while configuring loop")
Signed-off-by: Zhong Jinghua <zhongjinghua@huawei.com>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Link: https://lore.kernel.org/r/20230221095027.3656193-1-zhongjinghua@huaweicloud.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/loop.c