drm/gma500: refactor deprecated strncpy
authorJustin Stitt <justinstitt@google.com>
Tue, 19 Sep 2023 04:41:16 +0000 (04:41 +0000)
committerPatrik Jakobsson <patrik.r.jakobsson@gmail.com>
Wed, 27 Sep 2023 10:38:54 +0000 (12:38 +0200)
commit9edb071c8bd322482fa9cd1b60f26d0243479d76
treee9d2282c66834a3bcc5502ca434ff32222880483
parent78f54469b871db5ba8ea49abd4e5994e97bd525b
drm/gma500: refactor deprecated strncpy

`strncpy` is deprecated for use on NUL-terminated destination strings [1].

We should prefer more robust and less ambiguous string interfaces.

Since `chan->base.name` is expected to be NUL-terminated, a suitable
replacement is `strscpy` [2] due to the fact that it guarantees
NUL-termination on the destination buffer without also unnecessarily
NUL-padding (since `chan` is kzalloc'd already).

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html
Link: https://github.com/KSPP/linux/issues/90
Cc: linux-hardening@vger.kernel.org
Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230919-drivers-gpu-drm-gma500-oaktrail_lvds_i2c-c-v2-1-9ebe6983b4cb@google.com
drivers/gpu/drm/gma500/oaktrail_lvds_i2c.c