USB: core: return -EREMOTEIO on short usb_control_msg_recv()
authorJohan Hovold <johan@kernel.org>
Fri, 4 Dec 2020 08:51:10 +0000 (09:51 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Dec 2020 15:48:46 +0000 (16:48 +0100)
commit9dc9c8543aa0b9ef8852330b27cd2eef337bea18
treeca0686ad3d31d089f3abd093f7b40bbab4525796
parentbaf7df456b3848e4b6f8648e754e3a0f77fe700e
USB: core: return -EREMOTEIO on short usb_control_msg_recv()

Return -EREMOTEIO instead of -EINVAL on short control transfers when
using the new usb_control_msg_recv() helper.

EINVAL is used to report invalid arguments (e.g. to the helper) and
should not be used for unrelated errors.

Many driver currently return -EIO on short control transfers but since
host-controller drivers already use -EREMOTEIO for short transfers
whenever the URB_SHORT_NOT_OK flag is set, let's use that here as well.

This also allows usb_control_msg_recv() to eventually use
URB_SHORT_NOT_OK without changing the return value again.

Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20201204085110.20055-4-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/message.c