altera-stapl: check for a null key before strcasecmp'ing it
authorColin Ian King <colin.king@canonical.com>
Sat, 24 Nov 2018 12:34:10 +0000 (12:34 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 Nov 2018 07:44:07 +0000 (08:44 +0100)
commit9ccb645683ef46e3c52c12c088a368baa58447d4
tree286d1dfc1f9762e2544caf151fb6af4ae3ce1842
parent5323ac5177c445c15f49c91fadf9539a0bc95fa9
altera-stapl: check for a null key before strcasecmp'ing it

Currently the null check on key is occurring after the strcasecmp on
the key, hence there is a potential null pointer dereference on key.
Fix this by checking if key is null first. Also replace the == 0
check on strcasecmp with just the ! operator.

Detected by CoverityScan, CID#1248787 ("Dereference before null check")

Fixes: fa766c9be58b ("[media] Altera FPGA firmware download module")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/altera-stapl/altera.c