sysctl: Reduce dput(child) calls in proc_sys_fill_cache()
authorMarkus Elfring <elfring@users.sourceforge.net>
Wed, 23 Oct 2024 14:54:59 +0000 (16:54 +0200)
committerJoel Granados <joel.granados@kernel.org>
Thu, 31 Oct 2024 10:39:55 +0000 (11:39 +0100)
commit9c738dae9534fbdf77c250132cba04e0822983b3
tree7531f36d7f5d2929964b7bddc7647d2140361d50
parenta883f2efa625e05305aa9f6fc7ca3fae99105412
sysctl: Reduce dput(child) calls in proc_sys_fill_cache()

Replace two dput(child) calls with one that occurs immediately before
the IS_ERR evaluation. This transformation can be performed because
dput() gets called regardless of the value returned by IS_ERR(res).

This issue was transformed by using a script for the
semantic patch language like the following.
<SmPL>
@extended_adjustment@
expression e, f != { mutex_unlock }, x, y;
@@
+f(e);
 if (...)
 {
 <+... when != \( e = x \| y(..., &e, ...) \)
-   f(e);
 ...+>
 }
-f(e);
</SmPL>

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Joel Granados <joel.granados@kernel.org>
Signed-off-by: Joel Granados <joel.granados@kernel.org>
fs/proc/proc_sysctl.c