drm/i915/gt: Clear the buffer pool age before use
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 15 Sep 2020 09:14:17 +0000 (10:14 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Tue, 15 Sep 2020 10:34:05 +0000 (11:34 +0100)
commit9bb34ff25c458a2a48fb61409df42f465ede37f8
tree5cf382fc64271aad3d6f501b816e895289b651dc
parent121ba69ffddc60df11da56f6d5b29bdb45c8eb80
drm/i915/gt: Clear the buffer pool age before use

If we create a new node, it is possible for the slab allocator to return
us a recently freed node. If that node was just retired, it will retain
the current jiffy as its node->age. There is then a miniscule window,
where as that node is retired, it will appear on the free list with an
incorrect age and be eligible for reuse by one thread, and then by a
second thread as the correct node->age is written.

Fixes: 06b73c2d0b65 ("drm/i915/gt: Delay taking the spinlock for grabbing from the buffer pool")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200915091417.4086-3-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/gt/intel_gt_buffer_pool.c