drm/i915: Replace all non-returning strlcpy with strscpy
authorAzeem Shaikh <azeemshaikh38@gmail.com>
Mon, 22 May 2023 15:52:28 +0000 (15:52 +0000)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Wed, 24 May 2023 13:38:56 +0000 (09:38 -0400)
commit9a2cb1b31c040e2f1b313e2f7921f0f5e6b66d82
treef19f542a6f2fd7138c323d83673f4e6c85975b2e
parent7a2280e8dcd2f1f436db9631287c0b21cf6a92b0
drm/i915: Replace all non-returning strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230522155228.2336755-1-azeemshaikh38@gmail.com
drivers/gpu/drm/i915/selftests/i915_perf.c