RDMA/hns: Fix memory leak on 'context' on error return path
authorColin Ian King <colin.king@canonical.com>
Thu, 24 Oct 2019 13:10:34 +0000 (14:10 +0100)
committerJason Gunthorpe <jgg@mellanox.com>
Mon, 28 Oct 2019 16:41:23 +0000 (13:41 -0300)
commit994195e1537074f56df216a9309f6e366cb35b67
treeb0575c3c09178339f825a46d180ed20eda1d4467
parent887803db866a7a4e1817a3cb8a3eee4e9879fed2
RDMA/hns: Fix memory leak on 'context' on error return path

Currently, the error return path when the call to function
dev->dfx->query_cqc_info fails will leak object 'context'. Fix this by
making the error return path via 'err' return return codes rather than
-EMSGSIZE, set ret appropriately for all error return paths and for the
memory leak now return via 'err' rather than just returning without
freeing context.

Link: https://lore.kernel.org/r/20191024131034.19989-1-colin.king@canonical.com
Addresses-Coverity: ("Resource leak")
Fixes: e1c9a0dc2939 ("RDMA/hns: Dump detailed driver-specific CQ")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/hns/hns_roce_restrack.c