libceph: Fix multiplication overflow in decode_new_up_state_weight()
authorRaphael Zimmer <raphael.zimmer@tu-ilmenau.de>
Wed, 27 May 2026 14:06:17 +0000 (16:06 +0200)
committerIlya Dryomov <idryomov@gmail.com>
Thu, 23 Jul 2026 18:29:40 +0000 (20:29 +0200)
commit98917a499ec7064c14fc56d180a4fd636fc2784c
treeb15b3d4d8aae42db150494587e84a8ec8784c6e2
parent1590cf0329716306e948a8fc29f1d3ee87d3989f
libceph: Fix multiplication overflow in decode_new_up_state_weight()

If a message of type CEPH_MSG_OSD_MAP contains a (maliciously) corrupted
osdmap, out-of-bounds memory accesses may occur in
decode_new_up_state_weight(). This happens because the bounds check for
the new_state part is based on calculating its length depending on a len
value read from the incoming message. This calculation may overflow
leading to an incorrect bounds check. Subsequently, out-of-bounds reads
may occur when decoding this part.

This patch switches the multiplication to use check_mul_overflow() to
abort processing the osdmap if an overflow occurred. Therefore,
osdmaps/messages containing large values for len that result in a
multiplication overflow are treated as invalid.

[ idryomov: rename new_state_len -> new_state_item_size, formatting ]

Cc: stable@vger.kernel.org
Fixes: 930c53286977 ("libceph: apply new_state before new_up_client on incrementals")
Signed-off-by: Raphael Zimmer <raphael.zimmer@tu-ilmenau.de>
Reviewed-by: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
net/ceph/osdmap.c