can: pch_can: pch_can_rx_normal: fix use after free
authorVincent Mailhol <mailhol.vincent@wanadoo.fr>
Tue, 23 Nov 2021 11:16:54 +0000 (20:16 +0900)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Tue, 7 Dec 2021 08:08:36 +0000 (09:08 +0100)
commit94cddf1e9227a171b27292509d59691819c458db
tree2a83bf59c0445119ec1851140f21156c549484fe
parent4dbb0dad8e63fcd0b5a117c2861d2abe7ff5f186
can: pch_can: pch_can_rx_normal: fix use after free

After calling netif_receive_skb(skb), dereferencing skb is unsafe.
Especially, the can_frame cf which aliases skb memory is dereferenced
just after the call netif_receive_skb(skb).

Reordering the lines solves the issue.

Fixes: b21d18b51b31 ("can: Topcliff: Add PCH_CAN driver.")
Link: https://lore.kernel.org/all/20211123111654.621610-1-mailhol.vincent@wanadoo.fr
Cc: stable@vger.kernel.org
Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/pch_can.c