MIPS: bpf: Fix uninitialised target compiler error
authorMatt Redfearn <matt.redfearn@imgtec.com>
Wed, 27 Sep 2017 08:14:58 +0000 (09:14 +0100)
committerRalf Baechle <ralf@linux-mips.org>
Mon, 9 Oct 2017 12:53:38 +0000 (14:53 +0200)
commit94c3390ab84a6b449accc7351ffda4a0c17bdb92
treef0d37004c667b22456319c4a36f19457a7e78bba
parent8a5776a5f49812d29fe4b2d0a2d71675c3facf3f
MIPS: bpf: Fix uninitialised target compiler error

Compiling ebpf_jit.c with gcc 4.9 results in a (likely spurious)
compiler warning, as gcc has detected that the variable "target" may be
used uninitialised. Since -Werror is active, this is treated as an error
and causes a kernel build failure whenever CONFIG_MIPS_EBPF_JIT is
enabled.

arch/mips/net/ebpf_jit.c: In function 'build_one_insn':
arch/mips/net/ebpf_jit.c:1118:80: error: 'target' may be used
uninitialized in this function [-Werror=maybe-uninitialized]
    emit_instr(ctx, j, target);
                                                                                ^
cc1: all warnings being treated as errors

Fix this by initialising "target" to 0. If it really is used
uninitialised this would result in a jump to 0 and a detectable run time
failure.

Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com>
Fixes: b6bd53f9c4e8 ("MIPS: Add missing file for eBPF JIT.")
Cc: James Hogan <james.hogan@imgtec.com>
Cc: David Daney <david.daney@cavium.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Colin Ian King <colin.king@canonical.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: linux-mips@linux-mips.org
Cc: linux-kernel@vger.kernel.org
Cc: <stable@vger.kernel.org> # v4.13+
Patchwork: https://patchwork.linux-mips.org/patch/17375/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
arch/mips/net/ebpf_jit.c