selftests/bpf: Return true/false (not 1/0) from bool functions
authorLinkui Xiao <xiaolinkui@kylinos.cn>
Thu, 14 Jul 2022 01:56:47 +0000 (09:56 +0800)
committerAndrii Nakryiko <andrii@kernel.org>
Thu, 14 Jul 2022 06:09:16 +0000 (23:09 -0700)
commit94bf6aad5dbed1c93618035ec31b37927538c276
tree735072897a5198e35c844c07e4d2dc2ddaf73b43
parentbf3f00378524adae16628cbadbd11ba7211863bb
selftests/bpf: Return true/false (not 1/0) from bool functions

Return boolean values ("true" or "false") instead of 1 or 0 from bool
functions.  This fixes the following warnings from coccicheck:

tools/testing/selftests/bpf/progs/test_xdp_noinline.c:407:9-10: WARNING:
return of 0/1 in function 'decap_v4' with return type bool
tools/testing/selftests/bpf/progs/test_xdp_noinline.c:389:9-10: WARNING:
return of 0/1 in function 'decap_v6' with return type bool
tools/testing/selftests/bpf/progs/test_xdp_noinline.c:290:9-10: WARNING:
return of 0/1 in function 'encap_v6' with return type bool
tools/testing/selftests/bpf/progs/test_xdp_noinline.c:264:9-10: WARNING:
return of 0/1 in function 'parse_tcp' with return type bool
tools/testing/selftests/bpf/progs/test_xdp_noinline.c:242:9-10: WARNING:
return of 0/1 in function 'parse_udp' with return type bool

Generated by: scripts/coccinelle/misc/boolreturn.cocci

Suggested-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Linkui Xiao <xiaolinkui@kylinos.cn>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Reviewed-by: Stanislav Fomichev <sdf@google.com>
Link: https://lore.kernel.org/bpf/20220714015647.25074-1-xiaolinkui@kylinos.cn
tools/testing/selftests/bpf/progs/test_xdp_noinline.c