raid5-cache: use try_cmpxchg in r5l_wake_reclaim
authorUros Bizjak <ubizjak@gmail.com>
Thu, 20 Oct 2022 15:51:04 +0000 (17:51 +0200)
committerSong Liu <song@kernel.org>
Mon, 14 Nov 2022 17:35:50 +0000 (09:35 -0800)
commit9487a0f6855c1a28e4e39d41545cd19ed417c015
tree09b4b8c272be00cdb285275f17b11119bb167643
parent3bd548e5b819b8c0f2c9085de775c5c7bff9052f
raid5-cache: use try_cmpxchg in r5l_wake_reclaim

Use try_cmpxchg instead of cmpxchg (*ptr, old, new) == old in
r5l_wake_reclaim. 86 CMPXCHG instruction returns success in ZF flag, so
this change saves a compare after cmpxchg (and related move instruction in
front of cmpxchg).

Also, try_cmpxchg implicitly assigns old *ptr value to "old" when cmpxchg
fails. There is no need to re-read the value in the loop.

Note that the value from *ptr should be read using READ_ONCE to prevent
the compiler from merging, refetching or reordering the read.

No functional change intended.

Cc: Song Liu <song@kernel.org>
Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Signed-off-by: Song Liu <song@kernel.org>
drivers/md/raid5-cache.c