block: make blk_crypto_rq_bio_prep() able to fail
authorEric Biggers <ebiggers@google.com>
Wed, 16 Sep 2020 03:53:14 +0000 (20:53 -0700)
committerJens Axboe <axboe@kernel.dk>
Mon, 5 Oct 2020 16:47:43 +0000 (10:47 -0600)
commit93f221ae08381e994ac9f9ff6aa743e612e49718
treefe3f7bb6254559fb0d7a84fc467389a5af30c821
parent07560151db960d26b425410d6fd778e6757a5da2
block: make blk_crypto_rq_bio_prep() able to fail

blk_crypto_rq_bio_prep() assumes its gfp_mask argument always includes
__GFP_DIRECT_RECLAIM, so that the mempool_alloc() will always succeed.

However, blk_crypto_rq_bio_prep() might be called with GFP_ATOMIC via
setup_clone() in drivers/md/dm-rq.c.

This case isn't currently reachable with a bio that actually has an
encryption context.  However, it's fragile to rely on this.  Just make
blk_crypto_rq_bio_prep() able to fail.

Suggested-by: Satya Tangirala <satyat@google.com>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Mike Snitzer <snitzer@redhat.com>
Reviewed-by: Satya Tangirala <satyat@google.com>
Cc: Miaohe Lin <linmiaohe@huawei.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-core.c
block/blk-crypto-internal.h
block/blk-crypto.c
block/blk-mq.c