xfs: don't return -EFSCORRUPTED from repair when resources cannot be grabbed
authorDarrick J. Wong <djwong@kernel.org>
Mon, 7 Nov 2022 01:03:17 +0000 (17:03 -0800)
committerDarrick J. Wong <djwong@kernel.org>
Wed, 16 Nov 2022 23:25:03 +0000 (15:25 -0800)
commit93b0c58ed04b6cbe45354f23bb5628fff31f9084
treecfbae54c48b7b7ba4538ecdb01f38f20e6a76c75
parent6bf2f87915970160ded16c310e2e8887deff97a2
xfs: don't return -EFSCORRUPTED from repair when resources cannot be grabbed

If we tried to repair something but the repair failed with -EDEADLOCK,
that means that the repair function couldn't grab some resource it
needed and wants us to try again.  If we try again (with TRY_HARDER) but
still can't get all the resources we need, the repair fails and errors
remain on the filesystem.

Right now, repair returns the -EDEADLOCK to the caller as -EFSCORRUPTED,
which results in XFS_SCRUB_OFLAG_CORRUPT being passed out to userspace.
This is not correct because repair has not determined that anything is
corrupt.  If the repair had been invoked on an object that could be
optimized but wasn't corrupt (OFLAG_PREEN), the inability to grab
resources will be reported to userspace as corrupt metadata, and users
will be unnecessarily alarmed that their suboptimal metadata turned into
a corruption.

Fix this by returning zero so that the results of the actual scrub will
be copied back out to userspace.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
fs/xfs/scrub/repair.c