projects / linux-2.6-microblaze.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: cc365dc) | patch
mei: fix incorrect logical operator in if statement
authorColin Ian King <colin.king@canonical.com>
Tue, 19 Dec 2017 17:35:30 +0000 (17:35 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 2 Jan 2018 16:09:29 +0000 (17:09 +0100)
commit912ed8afd6432f1c7c084ccd752139debc2f7014
tree2e464ea111fc50d820e351622bd63363af097c74tree | snapshot
parentcc365dcf0e56271bedf3de95f88922abe248e951commit | diff
mei: fix incorrect logical operator in if statement

The current expression using the || operator is always true because
dev->dev_state cannot be equal to two different values at the same time.
Fix this by replacing the || with &&.

Detected by CoverityScan, CID#1463042 ("Constant expression result")

Fixes: 8d52af6795c0 ("mei: speed up the power down flow")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/mei/hw-me.c diff | blob | history
MicroBlaze GIT Repository