kunit: Fix possible memory leak in kunit_filter_suites()
authorJinjie Ruan <ruanjinjie@huawei.com>
Sun, 3 Sep 2023 07:10:28 +0000 (15:10 +0800)
committerShuah Khan <skhan@linuxfoundation.org>
Tue, 5 Sep 2023 18:30:06 +0000 (12:30 -0600)
commit9076bc476d7ebf0565903c4b048442131825c1c3
treea7406d60f0f2ed73b1b47fa47187271383ec2e62
parent2b56a4b79b7b3086e842d39611db4e19b19dbe2a
kunit: Fix possible memory leak in kunit_filter_suites()

If both filter_glob and filters are not NULL, and kunit_parse_glob_filter()
succeed, but kcalloc parsed_filters fails, the suite_glob and test_glob of
parsed kzalloc in kunit_parse_glob_filter() will be leaked.

As Rae suggested, assign -ENOMEM to *err to correctly free copy and goto
free_parsed_glob to free the suite/test_glob of parsed.

Fixes: 1c9fd080dffe ("kunit: fix uninitialized variables bug in attributes filtering")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Suggested-by: Rae Moar <rmoar@google.com>
Reviewed-by: David Gow <davidgow@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
lib/kunit/executor.c