bpf: Notify user if we ever hit a bpf_snprintf verifier bug
authorFlorent Revest <revest@chromium.org>
Thu, 22 Apr 2021 23:55:42 +0000 (01:55 +0200)
committerAlexei Starovoitov <ast@kernel.org>
Fri, 23 Apr 2021 16:58:21 +0000 (09:58 -0700)
commit8e8ee109b02c0e90021d63cd20dd0157c021f7a4
tree8abf8acf65295cbadcaeea0b76b1437f02c7e535
parente7a1c1300891d8f11d05b42665e299cc22a4b383
bpf: Notify user if we ever hit a bpf_snprintf verifier bug

In check_bpf_snprintf_call(), a map_direct_value_addr() of the fmt map
should never fail because it has already been checked by
ARG_PTR_TO_CONST_STR. But if it ever fails, it's better to error out
with an explicit debug message rather than silently fail.

Reported-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: Florent Revest <revest@chromium.org>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20210422235543.4007694-2-revest@chromium.org
kernel/bpf/verifier.c