arm64: compat: Always use sigpage for sigreturn trampoline
authorWill Deacon <will@kernel.org>
Mon, 22 Jun 2020 12:09:49 +0000 (13:09 +0100)
committerWill Deacon <will@kernel.org>
Tue, 23 Jun 2020 13:56:24 +0000 (14:56 +0100)
commit8e411be6aad1387f40d60cb2c11d3260222c590b
treee647890d66331188c0b6fa42d6dfcf5737fc667c
parenta39060b009ca0b5b5fe0c0dab85ed437531aab52
arm64: compat: Always use sigpage for sigreturn trampoline

The 32-bit sigreturn trampoline in the compat sigpage matches the binary
representation of the arch/arm/ sigpage exactly. This is important for
debuggers (e.g. GDB) and unwinders (e.g. libunwind) since they rely
on matching the instruction sequence in order to identify that they are
unwinding through a signal. The same cannot be said for the sigreturn
trampoline in the compat vDSO, which defeats the unwinder heuristics and
instead attempts to use unwind directives for the unwinding. This is in
contrast to arch/arm/, which never uses the vDSO for sigreturn.

Ensure compatibility with arch/arm/ and existing unwinders by always
using the sigpage for the sigreturn trampoline, regardless of the
presence of the compat vDSO.

Reviewed-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Reviewed-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Will Deacon <will@kernel.org>
arch/arm64/kernel/signal32.c