ext4: check for allocation block validity with block group locked
authorTheodore Ts'o <tytso@mit.edu>
Thu, 12 Jul 2018 23:08:05 +0000 (19:08 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 12 Jul 2018 23:08:05 +0000 (19:08 -0400)
commit8d5a803c6a6ce4ec258e31f76059ea5153ba46ef
tree1efe5596c31c67ad7a80006b6930ebe66373ed31
parent362eca70b53389bddf3143fe20f53dcce2cfdf61
ext4: check for allocation block validity with block group locked

With commit 044e6e3d74a3: "ext4: don't update checksum of new
initialized bitmaps" the buffer valid bit will get set without
actually setting up the checksum for the allocation bitmap, since the
checksum will get calculated once we actually allocate an inode or
block.

If we are doing this, then we need to (re-)check the verified bit
after we take the block group lock.  Otherwise, we could race with
another process reading and verifying the bitmap, which would then
complain about the checksum being invalid.

https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1780137

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
fs/ext4/balloc.c
fs/ext4/ialloc.c