platform/x86/intel/ifs: Call release_firmware() when handling errors.
authorJithu Joseph <jithu.joseph@intel.com>
Thu, 25 Jan 2024 08:22:50 +0000 (00:22 -0800)
committerHans de Goede <hdegoede@redhat.com>
Fri, 26 Jan 2024 19:12:16 +0000 (20:12 +0100)
commit8c898ec07a2fc1d4694e81097a48e94a3816308d
tree316ecd2b1f894a786f991c3f65d5107da7b8e5c0
parenta692a86efe97fe0aba7cb15f38cbce866c080689
platform/x86/intel/ifs: Call release_firmware() when handling errors.

Missing release_firmware() due to error handling blocked any future image
loading.

Fix the return code and release_fiwmare() to release the bad image.

Fixes: 25a76dbb36dd ("platform/x86/intel/ifs: Validate image size")
Reported-by: Pengfei Xu <pengfei.xu@intel.com>
Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
Signed-off-by: Ashok Raj <ashok.raj@intel.com>
Tested-by: Pengfei Xu <pengfei.xu@intel.com>
Reviewed-by: Tony Luck <tony.luck@intel.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20240125082254.424859-2-ashok.raj@intel.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/intel/ifs/load.c