net: usb: usbnet: fix name regression
authorOliver Neukum <oneukum@suse.com>
Thu, 17 Oct 2024 07:18:37 +0000 (09:18 +0200)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 22 Oct 2024 11:24:26 +0000 (13:24 +0200)
commit8a7d12d674ac6f2147c18f36d1e15f1a48060edf
tree2dde48109aa90547d82365db867303b4fb8039c1
parentf7b4cf0306bbea500a613e4b618576452c1df4ba
net: usb: usbnet: fix name regression

The fix for MAC addresses broke detection of the naming convention
because it gave network devices no random MAC before bind()
was called. This means that the check for the local assignment bit
was always negative as the address was zeroed from allocation,
instead of from overwriting the MAC with a unique hardware address.

The correct check for whether bind() has altered the MAC is
done with is_zero_ether_addr

Signed-off-by: Oliver Neukum <oneukum@suse.com>
Reported-by: Greg Thelen <gthelen@google.com>
Diagnosed-by: John Sperbeck <jsperbeck@google.com>
Fixes: bab8eb0dd4cb9 ("usbnet: modern method to get random MAC")
Link: https://patch.msgid.link/20241017071849.389636-1-oneukum@suse.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/usb/usbnet.c