drm/stm: ltdc: fix late dereference check
authorRaphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
Mon, 15 May 2023 12:38:18 +0000 (14:38 +0200)
committerPhilippe Cornu <philippe.cornu@foss.st.com>
Fri, 26 May 2023 11:31:22 +0000 (13:31 +0200)
commit898a9e3f56db9860ab091d4bf41b6caa99aafc3d
treefeccb1aa77b0e5247555a8fc49fcd25e667989d8
parent34235f54b021ca75ab89d8af8d7f1fc420eaded0
drm/stm: ltdc: fix late dereference check

In ltdc_crtc_set_crc_source(), struct drm_crtc was dereferenced in a
container_of() before the pointer check. This could cause a kernel panic.

Fix this smatch warning:
drivers/gpu/drm/stm/ltdc.c:1124 ltdc_crtc_set_crc_source() warn: variable dereferenced before check 'crtc' (see line 1119)

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/lkml/202212241802.zeLFZCXB-lkp@intel.com/
Reported-by: Dan Carpenter <error27@gmail.com>
Closes: https://lore.kernel.org/lkml/202212241802.zeLFZCXB-lkp@intel.com/
Signed-off-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
Acked-by: Philippe Cornu <philippe.cornu@foss.st.com>
Signed-off-by: Philippe Cornu <philippe.cornu@foss.st.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230515123818.93971-1-raphael.gallais-pou@foss.st.com
drivers/gpu/drm/stm/ltdc.c