net/mlx5e: Fix use-after-free in mlx5e_stats_grp_sw_update_stats
authorSaeed Mahameed <saeedm@nvidia.com>
Sat, 12 Mar 2022 00:53:53 +0000 (16:53 -0800)
committerJakub Kicinski <kuba@kernel.org>
Mon, 14 Mar 2022 22:04:39 +0000 (15:04 -0700)
commit8772cc499bff844cf00d1b0b4428633d77c60a0d
tree4acacb0b1d781390f5e03e885220db1729518b95
parent3c2dfb735b4a9239e2b8170e88aaddbf987d9798
net/mlx5e: Fix use-after-free in mlx5e_stats_grp_sw_update_stats

We need to sync page pool stats only for active channels. Reading ethtool
stats on a down netdev or a netdev with modified number of channels will
result in a user-after-free, trying to access page pools that are freed
already.

BUG: KASAN: use-after-free in mlx5e_stats_grp_sw_update_stats+0x465/0xf80
Read of size 8 at addr ffff888004835e40 by task ethtool/720

Fixes: cc10e84b2ec3 ("mlx5: add support for page_pool_get_stats")
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Reported-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Joe Damato <jdamato@fastly.com>
Link: https://lore.kernel.org/r/20220312005353.786255-1-saeed@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/en_stats.c