tty: n_gsm: clean up implicit CR bit encoding in address field
authorDaniel Starke <daniel.starke@siemens.com>
Wed, 20 Apr 2022 10:13:46 +0000 (03:13 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Apr 2022 14:54:22 +0000 (16:54 +0200)
commit871277738426e188cf5b8eb7a2fbee1e27a496cb
tree988ee61129130afbc873e9e8889485f4d03091bf
parent538668d7d2deb39bc3aa3b9af24fd779bd8f8b82
tty: n_gsm: clean up implicit CR bit encoding in address field

n_gsm is based on the 3GPP 07.010 and its newer version is the 3GPP 27.010.
See https://portal.3gpp.org/desktopmodules/Specifications/SpecificationDetails.aspx?specificationId=1516
The changes from 07.010 to 27.010 are non-functional. Therefore, I refer to
the newer 27.010 here. Chapter 5.2.1.2 describes the encoding of the
address field within the frame header. It is made up of the DLCI address,
command/response (CR) bit and EA bit.
Use the predefined CR value instead of a plain 2 in alignment to the
remaining code and to make the encoding obvious.

Signed-off-by: Daniel Starke <daniel.starke@siemens.com>
Link: https://lore.kernel.org/r/20220420101346.3315-3-daniel.starke@siemens.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/n_gsm.c