drm/i915/region: fix max size calculation
authorMatthew Auld <matthew.auld@intel.com>
Wed, 21 Oct 2020 10:36:06 +0000 (11:36 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Wed, 21 Oct 2020 18:21:04 +0000 (19:21 +0100)
commit83ebef47f8ebe320d5c5673db82f9903a4f40a69
tree57e02bd896d86ae643dd2d630bc7b528bf8cfb32
parent8f2b4b684ae530cf7623cc1df22f05460b84cc5e
drm/i915/region: fix max size calculation

We are incorrectly limiting the max allocation size as per the mm
max_order, which is effectively the largest power-of-two that we can fit
in the region size. However, it's normal to setup the region or
allocator with a non-power-of-two size(for example 3G), which we should
already handle correctly, except it seems for the early too-big-check.

v2: make sure we also exercise the I915_BO_ALLOC_CONTIGUOUS path, which
is quite different, since for that we are actually limited by the
largest power-of-two that we can fit within the region size. (Chris)

Fixes: b908be543e44 ("drm/i915: support creating LMEM objects")
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: CQ Tang <cq.tang@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20201021103606.241395-1-matthew.auld@intel.com
drivers/gpu/drm/i915/intel_memory_region.c
drivers/gpu/drm/i915/selftests/intel_memory_region.c
drivers/gpu/drm/i915/selftests/mock_region.c