gpio/grgpio: fix deadlock in grgpio_irq_unmap()
authorAlexandre Courbot <acourbot@nvidia.com>
Mon, 17 Aug 2015 08:23:52 +0000 (17:23 +0900)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 17 Aug 2015 08:56:24 +0000 (10:56 +0200)
commit7fa25937542358bfa01ef5c5a1e9a00bd164c000
treed4edc6026912b6b8ad9450aa84f26f06d4b23794
parentac49fbd1f9d437cca7234473850aef4165779383
gpio/grgpio: fix deadlock in grgpio_irq_unmap()

As reported by Alexey Khoroshilov:

    grgpio_irq_unmap() code looks quite suspicious regarding usage of
    priv->bgc.lock spinlock.

    It locks the spinlock in line 310:

spin_lock_irqsave(&priv->bgc.lock, flags);

    and then it can call grgpio_set_imask() in line 317:

grgpio_set_imask(priv, i, 0);

    But grgpio_set_imask() unconditionally locks the spinlock by itself.

Fix this by moving the spinlock acquisition outside of
grgpio_set_imask().

Found by Linux Driver Verification project (linuxtesting.org).

Reported-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Cc: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Andreas Larsson <andreas@gaisler.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-grgpio.c