drm/msm/dpu: check for valid hw_pp in dpu_encoder_helper_phys_cleanup
authorAbhinav Kumar <quic_abhinavk@quicinc.com>
Wed, 17 Jan 2024 19:41:09 +0000 (11:41 -0800)
committerAbhinav Kumar <quic_abhinavk@quicinc.com>
Wed, 24 Jan 2024 23:16:35 +0000 (15:16 -0800)
commit7f3d03c48b1eb6bc45ab20ca98b8b11be25f9f52
tree6290facd591dfa53edf2b1afd42c8502b2bb6d57
parentfcccdafd91f8bdde568b86ff70848cf83f029add
drm/msm/dpu: check for valid hw_pp in dpu_encoder_helper_phys_cleanup

The commit 8b45a26f2ba9 ("drm/msm/dpu: reserve cdm blocks for writeback
in case of YUV output") introduced a smatch warning about another
conditional block in dpu_encoder_helper_phys_cleanup() which had assumed
hw_pp will always be valid which may not necessarily be true.

Lets fix the other conditional block by making sure hw_pp is valid
before dereferencing it.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Fixes: ae4d721ce100 ("drm/msm/dpu: add an API to reset the encoder related hw blocks")
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/574878/
Link: https://lore.kernel.org/r/20240117194109.21609-1-quic_abhinavk@quicinc.com
Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c