rtc: pcf85363/pcf85263: fix regmap error in set_time
authorBiwen Li <biwen.li@nxp.com>
Thu, 29 Aug 2019 02:14:18 +0000 (10:14 +0800)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Sun, 1 Sep 2019 06:48:28 +0000 (08:48 +0200)
commit7ef66122bdb3b839e9f51b76d7e600b6e21ef648
treeb45f2b2cd51840d0c4b3fa0504849a9cade156b0
parentc59a9fc7272e56ba0575b9fcc346c5e4bf16b39d
rtc: pcf85363/pcf85263: fix regmap error in set_time

Issue:
    - # hwclock -w
      hwclock: RTC_SET_TIME: Invalid argument

Why:
    - Relative commit: 8b9f9d4dc511 ("regmap: verify if register is
      writeable before writing operations"), this patch
      will always check for unwritable registers, it will compare reg
      with max_register in regmap_writeable.

    - The pcf85363/pcf85263 has the capability of address wrapping
      which means if you access an address outside the allowed range
      (0x00-0x2f) hardware actually wraps the access to a lower address.
      The rtc-pcf85363 driver will use this feature to configure the time
      and execute 2 actions in the same i2c write operation (stopping the
      clock and configure the time). However the driver has also
      configured the `regmap maxregister` protection mechanism that will
      block accessing addresses outside valid range (0x00-0x2f).

How:
    - Split of writing regs to two parts, first part writes control
      registers about stop_enable and resets, second part writes
      RTC time and date registers.

Signed-off-by: Biwen Li <biwen.li@nxp.com>
Link: https://lore.kernel.org/r/20190829021418.4607-1-biwen.li@nxp.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-pcf85363.c