mptcp: fix warn at shutdown time for unaccepted msk sockets
authorPaolo Abeni <pabeni@redhat.com>
Fri, 7 Aug 2020 17:03:53 +0000 (19:03 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sat, 8 Aug 2020 00:26:16 +0000 (17:26 -0700)
commit7ee2492635d862fac39bc5ef234ffd3d8e9f833b
tree7329742a968e4f3f25562f75c9defe83bb8f57a0
parent6bdb6211a61eaf91a22e9160b16795ee6c40f90d
mptcp: fix warn at shutdown time for unaccepted msk sockets

With commit b93df08ccda3 ("mptcp: explicitly track the fully
established status"), the status of unaccepted mptcp closed in
mptcp_sock_destruct() changes from TCP_SYN_RECV to TCP_ESTABLISHED.

As a result mptcp_sock_destruct() does not perform the proper
cleanup and inet_sock_destruct() will later emit a warn.

Address the issue updating the condition tested in mptcp_sock_destruct().
Also update the related comment.

Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/66
Reported-and-tested-by: Christoph Paasch <cpaasch@apple.com>
Fixes: b93df08ccda3 ("mptcp: explicitly track the fully established status")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/mptcp/subflow.c