devlink: move devlink reload notifications back in between _down() and _up() calls
authorJiri Pirko <jiri@nvidia.com>
Fri, 27 Jan 2023 15:50:40 +0000 (16:50 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 30 Jan 2023 08:37:46 +0000 (08:37 +0000)
commit7d7e9169a3ecdc14a4921b2130066ce26952c9e1
treebb1cafd91cfc140d198f8fb40fa1e6c87cdbbcab
parent166a1a5a12b056a389b8dc529033cafaa290ca7c
devlink: move devlink reload notifications back in between _down() and _up() calls

This effectively reverts commit 05a7f4a8dff1 ("devlink: Break parameter
notification sequence to be before/after unload/load driver").

Cited commit resolved a problem in mlx5 params implementation,
when param notification code accessed memory previously freed
during reload.

Now, when the params can be registered and unregistered when devlink
instance is registered, mlx5 code unregisters the problematic param
during devlink reload. The fix is therefore no longer needed.

Current behavior is a it problematic, as it sends DEL notifications even
in potential case when reload_down() call fails which might confuse
userspace notifications listener.

So move the reload notifications back where they were originally in
between reload_down() and reload_up() calls.

Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/devlink/leftover.c