bpf: Support narrow loads from bpf_sock_addr.user_port
authorAndrey Ignatov <rdna@fb.com>
Thu, 14 May 2020 01:50:27 +0000 (18:50 -0700)
committerAlexei Starovoitov <ast@kernel.org>
Fri, 15 May 2020 01:30:57 +0000 (18:30 -0700)
commit7aebfa1b3885b5aa29fcb4a596d0485ac463bbe8
tree63b1598db717838cec551892a04b6245c316539e
parent6a09815428547657f3ffd2f5c31ac2a191e7fdf3
bpf: Support narrow loads from bpf_sock_addr.user_port

bpf_sock_addr.user_port supports only 4-byte load and it leads to ugly
code in BPF programs, like:

volatile __u32 user_port = ctx->user_port;
__u16 port = bpf_ntohs(user_port);

Since otherwise clang may optimize the load to be 2-byte and it's
rejected by verifier.

Add support for 1- and 2-byte loads same way as it's supported for other
fields in bpf_sock_addr like user_ip4, msg_src_ip4, etc.

Signed-off-by: Andrey Ignatov <rdna@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Yonghong Song <yhs@fb.com>
Link: https://lore.kernel.org/bpf/c1e983f4c17573032601d0b2b1f9d1274f24bc16.1589420814.git.rdna@fb.com
include/uapi/linux/bpf.h
net/core/filter.c
tools/include/uapi/linux/bpf.h