arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered
authorDouglas Anderson <dianders@chromium.org>
Mon, 6 Nov 2023 22:43:28 +0000 (14:43 -0800)
committerBjorn Andersson <andersson@kernel.org>
Sun, 3 Dec 2023 04:58:49 +0000 (20:58 -0800)
commit7ac90b4cf107a3999b30844d7899e0331686b33b
treed7595d6bb7547737d49703d905de91e53ad7310a
parent2c21e5a84524381977b4744e906fb31862ac5809
arm64: dts: qcom: sc7180: Make watchdog bark interrupt edge triggered

On sc7180 when the watchdog timer fires your logs get filled with:
  watchdog0: pretimeout event
  watchdog0: pretimeout event
  watchdog0: pretimeout event
  ...
  watchdog0: pretimeout event

If you're using console-ramoops to debug crashes the above gets quite
annoying since it blows away any other log messages that might have
been there.

The issue is that the "bark" interrupt (AKA the "pretimeout"
interrupt) remains high until the watchdog is pet. Since we've got
things configured as "level" triggered we'll keep getting interrupted
over and over.

Let's switch to edge triggered. Now we'll get one interrupt when the
"bark" interrupt goes off and won't get another one until the "bark"
interrupt is cleared and asserts again.

This matches how many older Qualcomm SoCs have things configured.

Fixes: 28cc13e4060c ("arm64: dts: qcom: sc7180: Add watchdog bark interrupt")
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20231106144335.v2.1.Ic7577567baff921347d423b722de8b857602efb1@changeid
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
arch/arm64/boot/dts/qcom/sc7180.dtsi