ALSA: pcm: add more format names
authorDan Carpenter <error27@gmail.com>
Fri, 27 Aug 2010 20:02:15 +0000 (22:02 +0200)
committerTakashi Iwai <tiwai@suse.de>
Sat, 28 Aug 2010 09:59:33 +0000 (11:59 +0200)
commit7a28826ac73d31a379d93785d8fbd24ab492b0bd
tree3b3af569f7451b45941f9089494eb30487b7cb6f
parent3182c8a72b31414e043184a97b0d5d3c0d590168
ALSA: pcm: add more format names

There were some new formats added in commit 15c0cee6c809 "ALSA: pcm:
Define G723 3-bit and 5-bit formats".  That commit increased
SNDRV_PCM_FORMAT_LAST as well.  My concern is that there are a couple
places which do:

        for (i = 0; i < SNDRV_PCM_FORMAT_LAST; i++) {
                if (dummy->pcm_hw.formats & (1ULL << i))
                        snd_iprintf(buffer, " %s", snd_pcm_format_name(i));
        }

I haven't tested these but it looks like if "i" were equal to
SNDRV_PCM_FORMAT_G723_24 or higher then we might read past the end of
the array.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/pcm.c