kunit: string-stream: Simplify resource use
authorDavid Gow <davidgow@google.com>
Fri, 22 Jul 2022 17:15:30 +0000 (17:15 +0000)
committerShuah Khan <skhan@linuxfoundation.org>
Fri, 7 Oct 2022 16:15:22 +0000 (10:15 -0600)
commit78b1c6584fcedcf2d9687a4455c461859094cf04
treef55834f324f16c9854f1750ab49567d5ee685072
parent4e37057387cca749b7fbc8c77e3d86605117fffd
kunit: string-stream: Simplify resource use

Currently, KUnit's string streams are themselves "KUnit resources".
This is redundant since the stream itself is already allocated with
kunit_kzalloc() and will thus be freed automatically at the end of the
test.

string-stream is only used internally within KUnit, and isn't using the
extra features that resources provide like reference counting, being
able to locate them dynamically as "test-local variables", etc.

Indeed, the resource's refcount is never incremented when the
pointer is returned. The fact that it's always manually destroyed is
more evidence that the reference counting is unused.

Signed-off-by: David Gow <davidgow@google.com>
Signed-off-by: Daniel Latypov <dlatypov@google.com>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
lib/kunit/string-stream.c
lib/kunit/string-stream.h
lib/kunit/test.c