wifi: iwlwifi: mvm: fix a crash on 7265
authorEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Sun, 12 May 2024 04:31:06 +0000 (07:31 +0300)
committerJohannes Berg <johannes.berg@intel.com>
Wed, 29 May 2024 13:26:54 +0000 (15:26 +0200)
commit788e4c75f831d06fcfbbec1d455fac429521e607
tree11179e91e51f04f95e5534d5a7a69051dded2753
parent98b7017ddb914a32152ed9aec7468386fff85f8f
wifi: iwlwifi: mvm: fix a crash on 7265

Since IWL_FW_CMD_VER_UNKNOWN = 99, then my change to consider
cmd_ver >= 7 instead of cmd_ver = 7 included also firmwares that don't
advertise the command version at all. This made us send a command with a
bad size and because of that, the firmware hit a BAD_COMMAND immediately
after handling the REDUCE_TX_POWER_CMD command.

Fixes: 8f892e225f41 ("wifi: iwlwifi: mvm: support iwl_dev_tx_power_cmd_v8")
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Reviewed-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://msgid.link/20240512072733.eb20ff5050d3.Ie4fc6f5496cd296fd6ff20d15e98676f28a3cccd@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/fw.c